[Multicluster] Fix cache options for controller Manager #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicluster-e2e |
A few issues were introduced by antrea-io#5843 because of changes in the sigs.k8s.io/controller-runtime interface. The biggest issue was that the call to ctrl.NewManager was not using the Options object populated earlier in the setupManagerAndCertController function. Instead it was creating and using a new, incomplete Options object. Fixes antrea-io#6149 Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
fix-multicluster-controller-manager-cache-options
branch
from
ff9536d to
f7e8260
Compare
|
/test-multicluster-e2e |
antoninbas
commented
Mar 26, 2024
| podNamespace: {}, | ||
| } | ||
| } else { | ||
| // For a member, restict the cache to the controller's Namespace for the following objects. |
There was a problem hiding this comment.
@luolanzone I am not entirely sure how these objects are determined.
However, I removed mcv1alpha1.MemberClusterAnnounce, which doesn't exist in the member cluster.
There was a problem hiding this comment.
Yeah, it should be removed if we separate the filter for the leader and member.
The decoder is no longer injected automatically, it needs to be instantiated by us. Signed-off-by: Antonin Bas <[email protected]>
|
/test-multicluster-e2e |
|
|
|
/skip-all |
antoninbas
deleted the
fix-multicluster-controller-manager-cache-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues were introduced by #5843 because of changes in the sigs.k8s.io/controller-runtime interface.
The biggest issue was that the call to ctrl.NewManager was not using the Options object populated earlier in the setupManagerAndCertController function. Instead it was creating and using a new, incomplete Options object.
Fixes #6149